Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Upadate README #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex35mil merged 3 commits into shakacode:master from szyablitsky:readme-ci-section
Sep 28, 2015
Merged

Upadate README #98

alex35mil merged 3 commits into shakacode:master from szyablitsky:readme-ci-section
Sep 28, 2015

Conversation

@szyablitsky
Copy link
Contributor

@szyablitsky szyablitsky commented Sep 19, 2015

CI configuration

Copy link
Contributor Author

If we move away from Travis CI, then we lose info on proper CI configuration which now is only contained in .travis.yml

Copy link
Member

After merge of #96 it should be:

npm install
cd client && npm run build

fix for new build system
Copy link
Contributor Author

@alexfedoseev Fixed. Thanks!

Copy link
Member

Thanks! 👍 I'll merge it after #96

Copy link
Member

@szyablitsky #96 is merged.
Here is the final travis config: https://github.com/shakacode/react-webpack-rails-tutorial/blob/master/.travis.yml
Please make one more fix and I'll merge it to master. Thanks!

Copy link
Contributor Author

@alexfedoseev Done!

alex35mil added a commit that referenced this pull request Sep 28, 2015
@alex35mil alex35mil merged commit 88df62b into shakacode:master Sep 28, 2015
Copy link
Member

@szyablitsky Merged 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /