public/webpack/test/server-bundle.js (2)

1-1: Windows/dev ergonomics: guard against broken symlinks.

On Windows clones with core.symlinks=false, this may become a text file. Consider adding a setup step to (re)create the symlink locally and in CI, and documenting the requirement.

I can provide a small cross‐platform setup script (Bash + PowerShell) to ensure the link is correct on dev machines and CI.

---

1-1: Document the rationale and removal path.

Add a short README or comment in the repo (e.g., public/webpack/README.md) explaining this symlink, the ROR 16 hardcoded test lookup, and when it can be removed.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

config/initializers/react_on_rails.rb (2)

19-21: Apply RuboCop style nits (join + modifier if)

Use Rails.root.join and a one‐line guard, per the lints.

- if Rails.env.test?
- config.generated_assets_dir = File.join(Rails.root, "public", "packs")
- end
+ config.generated_assets_dir = Rails.root.join("public", "packs").to_s if Rails.env.test?

---

17-21: Avoid config drift by deriving from Shakapacker (alternative to the above diff)

Pull the path from Shakapacker so future output path changes don’t require touching this initializer.

- if Rails.env.test?
- config.generated_assets_dir = File.join(Rails.root, "public", "packs")
- end
+ if Rails.env.test?
+ config.generated_assets_dir =
+ if defined?(Shakapacker) && Shakapacker.respond_to?(:config)
+ Shakapacker.config.public_output_path.to_s
+ else
+ Rails.root.join("public", "packs").to_s
+ end
+ end

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

config/initializers/react_on_rails.rb (2)

17-27: Fix RuboCop violations and improve code style.

The pipeline is failing due to RuboCop violations that should be addressed:

1. Line 25-27: Use modifier if for the single-line conditional
2. Line 26: Use Rails.root.join instead of File.join for Rails path construction

Apply this diff to fix the style violations:

- # This configuration tells React on Rails where to find bundles in test environment.
- # Without this, it defaults to public/webpack/test/ instead of public/packs/
- if Rails.env.test?
- config.generated_assets_dir = File.join(Rails.root, "public", "packs")
- end
+ # This configuration tells React on Rails where to find bundles in test environment.
+ # Without this, it defaults to public/webpack/test/ instead of public/packs/
+ config.generated_assets_dir = Rails.root.join("public", "packs").to_s if Rails.env.test?

---

17-24: Consider refining the comment for clarity.

The comment describes this as a "workaround" and mentions "removed error handling," but based on the PR objectives, this appears to be the intended configuration approach for React on Rails 16. The comment could be more straightforward about the purpose.

Consider this more concise comment:

- # React on Rails 16 compatibility: Workaround for removed error handling
- #
- # BREAKING CHANGE in v16: React on Rails 14.2.1 had robust error handling that would
- # fallback to the Shakapacker output path when bundle lookup failed. This was removed
- # in v16.0.1.rc.2, causing it to look in the wrong directory during tests.
- #
- # This configuration tells React on Rails where to find bundles in test environment.
- # Without this, it defaults to public/webpack/test/ instead of public/packs/
+ # Configure React on Rails to use Shakapacker's output directory in test environment.
+ # This ensures compatibility with React on Rails 16+ which requires explicit
+ # generated_assets_dir configuration for non-default asset paths.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

app/controllers/comments_controller.rb (1)

105-105: Prefer hash ordering to avoid SQL string

Use Arel/hash to dodge string SQL and be idiomatic.

- @comments = Comment.order("id DESC")
+ @comments = Comment.order(id: :desc)

spec/rescript/rescript_spec.rb (2)

49-50: Typo in variable name
Rename for clarity.

- initital_comment_count = Comment.count
- new_comment_count = initital_comment_count + 1
+ initial_comment_count = Comment.count
+ new_comment_count = initial_comment_count + 1

---

57-57: Use eq for value equality (not equal which checks identity)

equal checks object identity; prefer eq for numeric comparisons to avoid brittle tests.

- expect(Comment.count).to equal(new_comment_count)
+ expect(Comment.count).to eq(new_comment_count)

- expect(Comment.count).to equal(initial_comment_count)
+ expect(Comment.count).to eq(initial_comment_count)

Also applies to: 67-67, 76-76, 84-84

spec/stimulus/turbo_spec.rb (2)

44-45: Typo in variable name
Rename for clarity.

- initital_comment_count = Comment.count
- new_comment_count = initital_comment_count + 1
+ initial_comment_count = Comment.count
+ new_comment_count = initial_comment_count + 1

---

52-52: Use eq for value equality
Replace equal with eq for numeric comparisons.

- expect(Comment.count).to equal(new_comment_count)
+ expect(Comment.count).to eq(new_comment_count)

- expect(Comment.count).to equal(initial_comment_count)
+ expect(Comment.count).to eq(initial_comment_count)

Also applies to: 61-61, 70-70, 79-79

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro