Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add ActionCable to rescript (#565) #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justin808 merged 3 commits into master from add-action-cable-to-rescipt-page
Nov 23, 2023

Conversation

@yassa-tamer
Copy link
Contributor

@yassa-tamer yassa-tamer commented Nov 20, 2023
edited by justin808
Loading

Adding ActionCable to the Rescript page to receive the new broadcasted comments. see the js example


This change is Reviewable

Copy link
Contributor

ahangarha commented Nov 20, 2023
edited
Loading

Don't worry about tests at this time. We mostly get false failures.

yassa-tamer reacted with thumbs up emoji

@@ -1 +1 @@
<%= react_component "RescriptShow", prerender: true %>
<%= react_component "RescriptShow", prerender: false %>
Copy link
Contributor

@ahangarha ahangarha Nov 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why turn off SSR?

Copy link
Contributor Author

@yassa-tamer yassa-tamer Nov 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it is an initial implementation, it is not done yet. I'll ping you when it is done.

ahangarha reacted with thumbs up emoji
@ahangarha ahangarha changed the title (削除) add ActionCable to rescript (#565) (削除ここまで) (追記) Add ActionCable to rescript (#565) (追記ここまで) Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alex35mil alex35mil Awaiting requested review from alex35mil

1 more reviewer

@ahangarha ahangarha ahangarha approved these changes

Reviewers whose approvals may not affect merge requirements

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /