-
Notifications
You must be signed in to change notification settings - Fork 380
Updates for ControlPlane deploy #548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ahangarha can we merge?
ahangarha
ahangarha
commented
Oct 6, 2023
@ahangarha
ahangarha
changed the title
(削除) Updates for ControlPlane deploy (削除ここまで)
(追記) WIP - Updates for ControlPlane deploy (追記ここまで)
Oct 10, 2023
@ahangarha
ahangarha
force-pushed
the
cpln-deploy-update
branch
from
October 17, 2023 09:43
c4c0514 to
33003e0
Compare
@justin808
justin808
force-pushed
the
cpln-deploy-update
branch
from
October 17, 2023 20:03
a3500b7 to
749e4ce
Compare
justin808
justin808
approved these changes
Oct 18, 2023
@justin808
justin808
changed the title
(削除) WIP - Updates for ControlPlane deploy (削除ここまで)
(追記) Updates for ControlPlane deploy (追記ここまで)
Oct 26, 2023
@Judahmeek @ahangarha can you fix failing test in separate PR?
@justin808 The failing CI is a typical issue with our tests. We need to fix our tests. The number of false failings is not normal in this repo. We already have an issue for this: #543.
I just rerun the test and it passed.
This is not an issue for this project but we should fix it once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Known issue: Control Plane doesn't persist the database. Though we want this, we need to recreate the database again. This is WIP.
Closes #532
This change is Reviewable