Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Test upgrade deps #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

@yassa-tamer
Copy link
Contributor

@yassa-tamer yassa-tamer commented Aug 10, 2023
edited by justin808
Loading

Test the upgrade deps branch.


This change is Reviewable

KhaledEmaraDev and others added 9 commits August 10, 2023 13:36
1. Bump all minor and patch versions of all packages.
2. Upgrade `autoprefixer`: Use `.browserslistrc` and delete `.postcssrc`
 Add it to `postcss.config.js`
 Install and add `postcss-preset-env` to `postcss.config.js`
3. Upgrade `immutable`: Explicitly convert all `Array`s to `List`s
4. Upgrae `marked`: Install `marked-gfm-heading-id` to support `gfm` opt
5. Upgrade `react-router`:
 a. Remove `exact`
 b. Use `Routes` instead of `Switch`.
 c. Import `StaticRouter` from `react-router-dom/server`.
 d. Use `element` instead of `component`
 e. Use absolute paths instead of relative in Links.
 f. Convert Two Components to Functional React ones in order to use
 `useLocation` hook.
 g. Use `isActive` in `className` instead of `activeClassName`.
 h. Use `Navigate` instead of `Redirect`.
 i. Reset state once redirected.
6. Upgrade `react-transition-group`:
 a. Use `TransitionGroup` and `CSSTransition` instead of
 `ReactCSSTransitionGroup`.
 b. Convert one component to a Functional React one to use `forwardRef`
 c. Add `nodeRef` as part of the state to track DOM nodes for animation
7. Install `typescript` because it's a needed peer depenency of
 `prettier-eslint-cli`
Signed-off-by: Khaled Emara <mail@KhaledEmara.dev>
This commit solve the warning of unexpected ref object provided for a div.
- Since we create the comment nodeRef in the CommentList component
 We don’t need it to be created during adding a comment.
- We shouldn’t change the props of a react component, It is not
 the best practice, So that this commit creates the nodeRef in the
 render function where it is used instead of the constructor function.
Copy link
Contributor

No need for new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahangarha ahangarha Awaiting requested review from ahangarha

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /