-
Notifications
You must be signed in to change notification settings - Fork 378
Updated babel-eslint and babel #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Turned off jsdoc, as new version of eslint fails * Turned on paded-blocks
@mbreining can you please try this out?
babel/babel-eslint#85 I fixed some issues, but more... Want to get team feedback on whether or not this is useful.
@mbreining @geoffevason What do you two think? FWIW, airbnb doesn't use it. I'm just throwing it out there so you can see what js-doc is about.
assets/javascripts/actions/CommentActions.js
5:2 error Missing JSDoc parameter description for 'url' valid-jsdoc
5:2 error Missing JSDoc parameter description for 'displaySpinner' valid-jsdoc
5:2 error Missing JSDoc return description valid-jsdoc
19:2 error Missing JSDoc parameter description for 'comments' valid-jsdoc
19:2 error Missing JSDoc return description valid-jsdoc
29:2 error Missing JSDoc parameter description for 'errorMessage' valid-jsdoc
29:2 error Missing JSDoc return description valid-jsdoc
39:2 error Missing JSDoc parameter description for 'comment' valid-jsdoc
39:2 error Missing JSDoc return description valid-jsdoc
assets/javascripts/actions/FormActions.js
6:2 error Missing JSDoc parameter description for 'comment' valid-jsdoc
6:2 error Missing JSDoc return description valid-jsdoc
16:2 error Missing JSDoc parameter description for 'comment' valid-jsdoc
16:2 error Missing JSDoc return description valid-jsdoc
16:2 error Expected JSDoc for 'url' but found 'comment' valid-jsdoc
assets/javascripts/utils/CommentsManager.js
4:2 error Missing JSDoc parameter description for 'url' valid-jsdoc
4:2 error Missing JSDoc return description valid-jsdoc
17:2 error Missing JSDoc parameter description for 'url' valid-jsdoc
17:2 error Missing JSDoc parameter description for 'comment' valid-jsdoc
17:2 error Missing JSDoc return description valid-jsdoc
✖ 19 problems (19 errors, 0 warnings)
* Fixed jsdoc issues * Upgraded gems to current and Ruby to current 2.2.1 * Added brakeman rakefile
@justin808
justin808
force-pushed
the
update-dependencies
branch
from
May 21, 2015 17:22
36f96d6 to
4cfa6ab
Compare
@mbreining @geoffevason Can you give this the 👍 ?
I fixed the jsdoc issues. Pretty nice! I dig it!
* Properly replacing default rake task
Looks good to me.
justin808
added a commit
that referenced
this pull request
May 21, 2015
Updated babel-eslint and babel, and other dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to shrinkwrap are due to update to 0.12.2 of node.