-
Couldn't load subscription status.
- Fork 11
Add prefix to generated table name #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prefix to generated table name #4
Conversation
Thanks @dodgeblaster ... thinking about it a bit deeper. What is the behavior that you would expect if a user changed the name input? 🤔
I added a check to see if:
- last deploy had no name defined, and current deploy has no name defined
or - last deploy had name defined, and current deploy has the same name defined
If not, it will go to the 'delete and create' branch of the if statement. It is keeping track of state through this.state. Will that be an issue for CI deploys? I am unfamiliar how state works in a CI context
...e value never conflicts with name input
@eahefnawy Made a few additional commits. Should be ready to be reviewed now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dodgeblaster
No description provided.