-
-
Notifications
You must be signed in to change notification settings - Fork 11
Added file IO, zip/unzip #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔨 issue: I would avoid messing with the ini_set and time limit, is a bit out of scope for this script. I'm fine with setting the error_reporting tho.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but it think its vital to actually see errors (for example php-zip mod not installed/activated). Maybe you can implement @init_set().
The time limit should be increased tho, because with the default limit of 30sec. some systems will not complete all the benchmarks. Here are some numbers as an example:
my raspberry pi 2 can only do 5 benchmarks in 30sec.
my rapsberry pi 3 can only do 10 benchmarks in 30sec.
total duration on my amd 5700G/win10/xampp/php8.2: 16sec.
total duration on my all-inkl.com server: 5sec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔨 issue: This cannot be hardcoded, it has to create a temp file with a builtin function (like https://www.php.net/manual/en/function.tmpfile.php) and check for existance before using it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔨 issue: Each test has to be atomic. It must not share anything with other tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for all of your feedback & thx for implementing my suggestions.
Integrated in #6
No description provided.