Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added file IO, zip/unzip #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alddesign wants to merge 1 commit into sergix44:master from alddesign:master
Closed

Added file IO, zip/unzip #3

alddesign wants to merge 1 commit into sergix44:master from alddesign:master

Conversation

@alddesign
Copy link

@alddesign alddesign commented Sep 29, 2023

No description provided.

Comment on lines +2 to +5
error_reporting(E_ALL);
ini_set ('display_startup_errors', 1);
ini_set ('display_errors', 1);
set_time_limit(180);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔨 issue: ‏I would avoid messing with the ini_set and time limit, is a bit out of scope for this script. I'm fine with setting the error_reporting tho.

Copy link
Author

@alddesign alddesign Jan 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but it think its vital to actually see errors (for example php-zip mod not installed/activated). Maybe you can implement @init_set().

The time limit should be increased tho, because with the default limit of 30sec. some systems will not complete all the benchmarks. Here are some numbers as an example:
my raspberry pi 2 can only do 5 benchmarks in 30sec.
my rapsberry pi 3 can only do 10 benchmarks in 30sec.
total duration on my amd 5700G/win10/xampp/php8.2: 16sec.
total duration on my all-inkl.com server: 5sec.


$V = '1.0';

$filePathPrefix = './6RgiwkCOIh8UrZE3';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔨 issue: ‏This cannot be hardcoded, it has to create a temp file with a builtin function (like https://www.php.net/manual/en/function.tmpfile.php) and check for existance before using it.

$benchmarks = [
'file-write' => function ($count = 1000)
{
global $filePathPrefix;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔨 issue: ‏ Each test has to be atomic. It must not share anything with other tests.

Copy link
Author

@alddesign alddesign Jan 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for all of your feedback & thx for implementing my suggestions.

Copy link
Owner

sergix44 commented Dec 6, 2023

Integrated in #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sergix44 sergix44 sergix44 requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /