-
Couldn't load subscription status.
- Fork 0
refactor: Ignore malformed tags #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatal: '' is not a valid tag name. – You can't create an empty tag with the git cli
@badboy
badboy
changed the title
(削除) [WIP] refactor: Ignore malformed tags (削除ここまで)
(追記) refactor: Ignore malformed tags (追記ここまで)
Jan 23, 2016
badboy
added a commit
that referenced
this pull request
Jan 23, 2016
refactor: Ignore malformed tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shoud ignore unparseable tags as discussed in semantic-rs/semantic-rs#19 (comment)
Though right above we still have an unwrap and an indexing operation. Is it possible to have empty tags? If so we need to change that as well.
Do not merge before I verified it.