-
Notifications
You must be signed in to change notification settings - Fork 71
refactor(esm): converted the package to esm-only #491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BREAKING CHANGE: is now an ES Module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really sure how to update these 👀
I tried to follow the same exact approach taken in semantic-release/error#249 - but let's see if it works 🤞
the error package is one of our simpler projects, so it may not provide enough examples for converting this whole plugin. you can find the PRs for the conversion of the other core plugins linked in the initial definition of semantic-release/semantic-release#2133, which are a bit more thorough.
i did kick off the execution of the verification workflow so you could see feedback from that to see how things currently stand. i recommend running the verification locally to get a faster feedback loop than you'll be able to get being dependent on a maintainer to kick off that workflow execution.
side note: we are working on updating our workflows to enable a simpler way to execute the same verification locally as happens in the ci workflows. if you would like to help us convert this project's workflow as a separate PR first, that might help make your local development exerience a bit simpler for this project. you can find a couple of examples of that progress here:
Uh oh!
There was an error while loading. Please reload this page.
BREAKING CHANGE:
semantic-release/gitis now an ES Module. Fixes #490I tried to follow the same exact approach taken in semantic-release/error#249 - but let's see if it works 🤞