-
Notifications
You must be signed in to change notification settings - Fork 399
feat(smartctl): update for smartmontools 7.5 #1471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ef3679a to
343d48a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I meant "Request changes".
Just a note, I plan to release the next bash-completion version really soon, as soon as tomorrow (Oct 27). Would be nice to get this included in that release if we can get it merged in time (can also wait for a couple of more days if that's what it takes, but would rather not).
Thanks for the info, will push a new version today.
343d48a to
72eb047
Compare
Done. Now always use _comp_compgen -P for prefixes, IMO easier to read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM basically.
72eb047 to
3375ba9
Compare
This is a retry of #1425.
Uses a different approach to let
menu-completeonly append a space if all alternatives allow this.