-
Couldn't load subscription status.
- Fork 219
add initialization example script #481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[test-all]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Container tests are passing. Unfortunately, I am not a database expert. @hhorak @fila43 WDYT?
As soon as @fila43 or @hhorak approve this pull request, we can merge it.
@aushacker Do we have a test for it? If not please create at least one.
@phracek Have had a look through the available tests, none of them seem to match the required procedure.
What is needed to test would be something like:
- Build base image
- Create a new image, layering in postgresql-init/initialize.sh
- Spin up the image from 2 in podman/docker
- Use a postgresql client to connect and query the quotes database
How does that fit in with the current testing procedure?
I do not see any problem with proposed example
[test-all]
@aushacker Thank you for this pull request. Please do following steps:
- rebase it agains the master
- call
make clean-versions - call
make generate-allwhich is mandatory, because ofdistgen checkis failing. It means that generated changes are different then we expect it.
Pull Request validation
Failed
🔴 Review - Missing review from a member (1 required)
Success
🟢 CI - All checks have passed
Uh oh!
There was an error while loading. Please reload this page.
A simple example showing how to configure a database with some test data.
When using ephemeral storage the database name specified by POSTGRESQL_DATABASE must be different from that created in the user provided script, otherwise the container will crash loop. This is due to the default scripts hard failing when trying to create a database that the user supplied init script has already created.
See issue #296 for narrative (known problem).