-
-
Notifications
You must be signed in to change notification settings - Fork 2
Try to implement custom darken lighten value input #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to implement custom darken lighten value input #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the brightness methods are probably the least set in stone. I found the darken/lighten from tinycolor to give unexpected results, do you feel the same? I see two options, either move away from tinycolor as a dependency, or list the adjustments differently- maybe just Brightness (-2), Brightness (-1) Brightness(+1) Brightness (+2) etc... in that solution even with an unreliable implementation there is less guarantee/expectation than something as strict as percentage, and it consolidates the commands and reduces the number of quickpicks.
For now though, your pull request looks great and if you could just add a placeholder or something to indicate whats expected on entry (eg percentage instead of number) i'll merge it. Awesome job with that, if there are any blocks moving forward that are hard to follow or anything like that just message me. Documenting methods is in the plans but until then just ask anytime
Also handle the case if user decides to put `%` sign at the end
Changed the prompt to containt Percent word.
Also, the input now will accept string containing % sign.
Uh oh!
There was an error while loading. Please reload this page.
Fixes #9
Is it intentional that label says
10%but the actual value is5?