Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Support ndarray 0.15 #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cassiersg wants to merge 1 commit into rust-ndarray:master from cassiersg:upgrade-ndarray

Conversation

@cassiersg
Copy link
Contributor

@cassiersg cassiersg commented Apr 6, 2021

No description provided.

Bump MSRV to 1.49.0 as this is the MSRV of ndarray 0.15.
Copy link
Collaborator

xd009642 commented Apr 6, 2021

So I was going to go for #74 as it also upgrades the other dependencies. However, you have updated the MSRV in the CI I don't suppose if I merge #74 you could just make this PR the CI change, just because there's a bunch of other code changes in that PR for deprecations in libraries that have changed etc

Copy link
Collaborator

xd009642 commented Apr 6, 2021

Or you could add the remote from that PR and merge it into this branch, but if you don't know how to do that with git don't worry we can go for the simpler approach 😅

Copy link
Collaborator

xd009642 commented Apr 6, 2021

Option C: I can just merge this one and get the other PR to minimise their work to just the dep updates

Copy link
Contributor Author

@xd009642 Sorry I missed #74 (I'm sending similar PRs to many projects to upgrade to ndarray 15.0 and I forgot to check if there wasn't a PR open.) I'll open a new PR with just the MSRV change on top of #74.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /