Skip to content

bump rand to 0.9.0 #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

TD-Sky wants to merge 1 commit into rust-ndarray:master

from TD-Sky:rand

Open

bump rand to 0.9.0 #105

TD-Sky wants to merge 1 commit into rust-ndarray:master from TD-Sky:rand

Conversation

Copy link

@TD-Sky TD-Sky commented Feb 25, 2025

No description provided.


 bump rand to 0.9.0

df79467

Copy link

Author

TD-Sky commented Mar 10, 2025

@bluss Would you kindly review and release a new patch version if possible?

Copy link

miikkas commented Oct 18, 2025

I did similar changes independently and successfully ran cargo test before checking if a PR was already up.

Some additional things of note that I think should not block merging this, since they are testing or benchmarking related:

ndarray-rand, currently with released version 0.15.0, is used for tests. That version of the crate uses rand 0.8, but the version on the main branch already uses 0.9.
- When a new version of ndarray-rand is released and the version in ndarray-stats is bumped to that, some of the tests and benches need to have the results from Uniform::new handled, I think by just unwrapping.
quickcheck version 0.9.2, also for tests, uses rand 0.7. The latest released version 1.0.3 uses rand 0.8. Their current main branch uses 0.9.
- Bumping quickcheck currently causes some new test failures. Possibly seems like its rummaging through more floating point numbers than previous versions. However, the failures I observed were due to stuff like NaNs, infs, or huge values around 10³⁰⁸.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment