-
Notifications
You must be signed in to change notification settings - Fork 482
automata: Fix crash in dense::DFA::from_bytes validation logic
#1295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Mrmaxmeier
wants to merge
2
commits into
rust-lang:master
from
Mrmaxmeier:fix-dense-dfa-from-bytes-crash
Closed
automata: Fix crash in dense::DFA::from_bytes validation logic
#1295
Mrmaxmeier
wants to merge
2
commits into
rust-lang:master
from
Mrmaxmeier:fix-dense-dfa-from-bytes-crash
+19
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurntSushi
pushed a commit
that referenced
this pull request
Oct 9, 2025
This was referenced Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Hi,
this PR fixes a panic in the
dense::DFA::from_bytesAPI. The validation step after loading a corrupted DFA currently panics inTransitionTable::validatedue to an invalidMatchState. This PR fixes this by validating theMatchStatefirst.I'm assuming that people are not using serialized automata with untrusted inputs, so I hope just opening a PR is fine 🙂