Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

ci: fix cross testing #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BurntSushi merged 1 commit into master from ag/ci-fix-cross
Aug 24, 2025
Merged

ci: fix cross testing #1284

BurntSushi merged 1 commit into master from ag/ci-fix-cross
Aug 24, 2025

Conversation

@BurntSushi
Copy link
Member

@BurntSushi BurntSushi commented Aug 24, 2025

I have no idea how CI was passing with this error in the CI
configuration. Apparently it is failing the master run, but the PRs
were not failing. Crazy.

@BurntSushi BurntSushi force-pushed the ag/ci-fix-cross branch 2 times, most recently from 65b097a to 9185efe Compare August 24, 2025 13:54
I have no idea how CI was passing with this error in the CI
configuration. Apparently it is failing the `master` run, but the PRs
were not failing. Crazy.
@BurntSushi BurntSushi merged commit 2695e29 into master Aug 24, 2025
18 checks passed
@BurntSushi BurntSushi deleted the ag/ci-fix-cross branch August 24, 2025 14:14
Copy link

GitHub Actions jobs with job definition errors simply don’t run, rather than be failed. Since the check was not required, it shows "green" on the PR (which only shows individual jobs) but red overall on the run page that also shows the syntax errors. The typical way to fix this is to make the job or a dependent of it a required check.

Copy link
Member Author

Thanks for adding context!

Do you mean this? I don't have access to do that on this repo. Everything is very stripped down in the rust-lang org. I'd probably have to go pester someone to do that.

Regardless, look at this page: https://github.com/rust-lang/regex/pull/1282/checks

If you look very closely, you can see there are "2 errors" under "Annotations". And there is a little ! icon with the number 5 next to the ci on:pull_request area. But those, as far as I can see, are the only indicators that anything has gone wrong. There are the missing jobs, but it's hard for the eye to notice what is missing. Crucially, there is a big green check mark in the top left corner. That to me says, "everything is okay" and then my eyes move on. This is absolutely terrible UI design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /