-
Couldn't load subscription status.
- Fork 483
ci: fix cross testing #1284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix cross testing #1284
Conversation
65b097a to
9185efe
Compare
I have no idea how CI was passing with this error in the CI configuration. Apparently it is failing the `master` run, but the PRs were not failing. Crazy.
9185efe to
f857324
Compare
amarshall
commented
Aug 24, 2025
GitHub Actions jobs with job definition errors simply don’t run, rather than be failed. Since the check was not required, it shows "green" on the PR (which only shows individual jobs) but red overall on the run page that also shows the syntax errors. The typical way to fix this is to make the job or a dependent of it a required check.
Thanks for adding context!
Do you mean this? I don't have access to do that on this repo. Everything is very stripped down in the rust-lang org. I'd probably have to go pester someone to do that.
Regardless, look at this page: https://github.com/rust-lang/regex/pull/1282/checks
If you look very closely, you can see there are "2 errors" under "Annotations". And there is a little ! icon with the number 5 next to the ci on:pull_request area. But those, as far as I can see, are the only indicators that anything has gone wrong. There are the missing jobs, but it's hard for the eye to notice what is missing. Crucially, there is a big green check mark in the top left corner. That to me says, "everything is okay" and then my eyes move on. This is absolutely terrible UI design.
I have no idea how CI was passing with this error in the CI
configuration. Apparently it is failing the
masterrun, but the PRswere not failing. Crazy.