-
Couldn't load subscription status.
- Fork 483
More efficient interval algorithms #1191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
+319
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of #1104 and specifically #1051 (comment), I can't accept these sorts of changes without first improving the testing strategy to ensure we don't ship regressions.
I haven't thought much about how to improve tests, but that's the first step here.
Understood, that's reasonable. Were the violations detected by the fuzzer added as regression tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This PR implements linear time and constant space algorithms for a few of the interval operations:
canonicalize: track the current "merge target", and merge each interval into the target if they overlap. The merge target is always shifted left as appropriate, so that we can simply truncate the list afterwards.negate: replace each interval with the negated interval to its left, then finally add the trailing interval on the right. Take care to avoid the leftmost and rightmost intervals if they're empty.union: two possible algorithms:push: use a binary search to insert the interval, the use the in-place sorted union.