-
Notifications
You must be signed in to change notification settings - Fork 435
Add an alternative AHT20 driver #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bors
merged 1 commit into
rust-embedded:master
from
anglerud:feature/add_new_aht20_driver
Feb 7, 2022
Merged
Add an alternative AHT20 driver #368
bors
merged 1 commit into
rust-embedded:master
from
anglerud:feature/add_new_aht20_driver
Feb 7, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@anglerud
anglerud
requested review from
a team,
RandomInsano,
berkus and
rahul-thakoor
as code owners
February 6, 2022 20:43
rust-highfive
commented
Feb 6, 2022
r? @jamesmunns
(rust-highfive has picked a reviewer for you, use r? to override)
@rust-highfive
rust-highfive
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-resources
labels
Feb 6, 2022
eldruin
eldruin
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Great post as well, thanks!
bors r+
Build succeeded:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote a new AHT20 driver and published a blog post about it. I created a new driver as the previous one took ownership of the delay device, denying it to other drivers and code. The existing AHT20 driver is also under the AGLP which is certainly a fine license, but not one I'd choose for a library myself.