Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Drivers: Add SHTCx #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 1 commit into rust-embedded:master from dbrgn:shtcx
Feb 11, 2020
Merged

Drivers: Add SHTCx #251

bors merged 1 commit into rust-embedded:master from dbrgn:shtcx
Feb 11, 2020

Conversation

@dbrgn
Copy link
Contributor

@dbrgn dbrgn commented Feb 11, 2020

Should be feature-complete. Supports SHTC1, SHTC3 and SHTW2.

Blogpost will probably follow.

Copy link

r? @korken89

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Feb 11, 2020
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

bors bot added a commit that referenced this pull request Feb 11, 2020
251: Drivers: Add SHTCx r=adamgreig a=dbrgn
Should be feature-complete. Supports SHTC1, SHTC3 and SHTW2.
Blogpost will probably follow.
Co-authored-by: Danilo Bargen <mail@dbrgn.ch>
Copy link
Contributor

bors bot commented Feb 11, 2020

Canceled

Copy link
Contributor Author

dbrgn commented Feb 11, 2020

@adamgreig thanks for the review! sorry, I had to force-push because the markup was broken 🙂 maybe you can re-review?

@dbrgn dbrgn requested a review from adamgreig February 11, 2020 23:11
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure!

bors r+

bors bot added a commit that referenced this pull request Feb 11, 2020
251: Drivers: Add SHTCx r=adamgreig a=dbrgn
Should be feature-complete. Supports SHTC1, SHTC3 and SHTW2.
Blogpost will probably follow.
Co-authored-by: Danilo Bargen <mail@dbrgn.ch>
Copy link
Contributor

bors bot commented Feb 11, 2020

@bors bors bot merged commit 80364cf into rust-embedded:master Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamgreig adamgreig adamgreig approved these changes

@berkus berkus Awaiting requested review from berkus berkus is a code owner

@rahul-thakoor rahul-thakoor Awaiting requested review from rahul-thakoor rahul-thakoor is a code owner

@RandomInsano RandomInsano Awaiting requested review from RandomInsano RandomInsano is a code owner

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /