-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add word that failed in CI's spell check to the whitelist #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry, I may have made a mistake in how I fix, so I'll go back to draft.
@masato-bkn
masato-bkn
changed the title
(削除) add
(追記) Add word that failed in CI's spell check to the whitelist. (追記ここまで)
Oct 19, 2023
Mange to codespell.txt (削除ここまで)
@masato-bkn
masato-bkn
changed the title
(削除) Add word that failed in CI's spell check to the whitelist. (削除ここまで)
(追記) Add word that failed in CI's spell check to the whitelist (追記ここまで)
Oct 19, 2023
koic
koic
reviewed
Oct 19, 2023
@masato-bkn Can you squash your commits into one?
@masato-bkn
masato-bkn
force-pushed
the
add-word-to-codespell
branch
from
October 19, 2023 08:41
b435c62 to
eb08a8d
Compare
Co-authored-by: Koichi ITO <koic.ito@gmail.com>
@masato-bkn
masato-bkn
force-pushed
the
add-word-to-codespell
branch
from
October 19, 2023 08:43
eb08a8d to
d4b93ae
Compare
🤔 shouldn't the spellchecker be configured to ignore URLs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I opened #348, the CI's spellcheck failed.
https://github.com/rubocop/rails-style-guide/actions/runs/6570237096/job/17847343002?pr=348
I addressed the issue by adding the relevant word to the whitelist.