Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

version bump #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rtfpessoa merged 4 commits into rtfpessoa:master from whyboris:version-bump
Feb 11, 2019
Merged

version bump #44

rtfpessoa merged 4 commits into rtfpessoa:master from whyboris:version-bump
Feb 11, 2019

Conversation

@whyboris
Copy link
Contributor

@whyboris whyboris commented Feb 4, 2019
edited
Loading

Update all the packages to their latest versions.

(削除) Note that yargs version 13.0.0 is out just not published to npm. I'm sure in a day or two it will be there: yargs/yargs#1288 (after which we'll want to update the yarn.lock in this PR) (削除ここまで) 👌

(削除) Note the minimum supported version of node has changed. Using anything lower than 8.12.0 will result in:
error codacy-coverage@3.4.0: The engine "node" is incompatible with this module. Expected version ">= 8.12.0". (削除ここまで)

@rtfpessoa -- please, either let me know which version you'd need to bump diff2html-cli to if this merges (or please change it yourself: https://github.com/rtfpessoa/diff2html-cli/blob/master/package.json#L3) 😅

update:

  • yargs v13 still hadn't been published to npm so I have v12 in this PR.
  • the codacity error I noted above doesn't seem to affect versions 6 and 7 so everything is fine 👌

Copy link
Owner

After we finish the other PRs we can continue this. Thanks for the start.

whyboris reacted with thumbs up emoji

Copy link
Owner

Can you update this one?
Then I will do a release.

whyboris reacted with thumbs up emoji whyboris reacted with hooray emoji whyboris reacted with heart emoji

Copy link
Contributor Author

Thank you for the swift feedback on all my PRs! I'm thrilled we'll have a new release shortly 😄

Cheers!

Copy link
Contributor Author

Curiously the Codacy/PR Quality Review has been Pending for several hours 😕

@rtfpessoa rtfpessoa merged commit ed487ad into rtfpessoa:master Feb 11, 2019
Copy link
Owner

Codacy has been having some issues with OSS projects.

@whyboris whyboris deleted the version-bump branch February 12, 2019 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /