-
-
Notifications
You must be signed in to change notification settings - Fork 111
add redux #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add redux #417
Conversation
hey sorry that we haven't gotten to this, its not forgotten we're just thinking about the best way to approach adding more options to the cli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note and this is a minor thing but if you change unrelated indentation it makes it a bit harder to review what the changes are, I've reverted some of the indentation changes to make it easier to review.
I added the changes also for the nativewindui layouts
I've merged the other state management pr which has caused some conflicts but I can help resolve those soon so that we can also get this merged
I've merged the other state management pr which has caused some conflicts but I can help resolve those soon so that we can also get this merged
If you want I can try to resolve those issues
@mickeypause yes that would be great, thank you 🙏
@mickeypause Are you still interested in making this addition? If so, can you rebase and ping me? Otherwise, I'll close this PR by the end of the month.
Similar question here @dannyhw re rebasing and testing
[cli] Added redux as a state management option
Description
Motivation and Context
Redux is still one of the most popular state management solutions used in production, with @reduxjs/toolkit having 3.6 million daily downloads. However, it takes a lot of effort to set it up due to the large amount of boilerplate code. These changes create a minimal Redux store and configure everything needed to start working with Redux immediately.
How Has This Been Tested?
Tested using
bun run testand manually tested each option.