-
-
Notifications
You must be signed in to change notification settings - Fork 31
upgrade to react-navigation 7 #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @cknitt, can I have a review? thanks :)
src/Stack.res
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With ReScript 11.1, we could get rid of the trailing unit everywhere.
src/Stack.res
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With ReScript 11.1, we could have a single binding with an optional param (without trailing unit) instead.
Co-authored-by: Christoph Knittel <ck@cca.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 🎉
Following : https://reactnavigation.org/docs/upgrading-from-6.x