-
-
Notifications
You must be signed in to change notification settings - Fork 31
chore: migrate to rescript #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate to rescript #44
Conversation
Hi! I finally had time to migrate my app to latest rescript dependencies and test this PR on a real project.
It work well thank you 😊
The only missing part that I think it's still useful are the @obj options functions in Navigators (bottomaTabBarOptions()in BottomTabs, materialTopTabBarOptions() in MaterialTopTabs, ...) because it's not yet possible to create Object without specifying option('a) attributes.
Thanks for this PR. I tried conversion a few months ago, but virtual class where being dropped entirely... It seems here there is something to cover this.
@Freddy03h if you have time, we can merge this in a wip branch & you can continue contributing from here. Sounds good to you ?
@Freddy03h up to continue the migration? or @cem2ran do you have time for this?
8b9c852
into
rescript-react-native:rescript-migration
Spent a few minutes migrating this. Used
rescript convert src/**/*.re. This converted everything except class types as mentioned in #42. I've converted the classes to the new object spread syntax.Haven't tested whether this works, as I currently don't use this at work, maybe someone else can test this draft PR and bring it to the finish line.
scriptsin Package.json should probably be updated further, e.g. format.