-
-
Notifications
You must be signed in to change notification settings - Fork 31
Fix NavigationContainer ref type #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NavigationContainer ref type #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I will ask for @Freddy03h review because he added this ref. I would like a confirmation that this change is ok as I don't use this ref (yet).
@MoOx @Freddy03h any updates? :)
Sorry for the delay!
I've tried this change on my own codebase to test it and it look good, thanks!
Hi @MoOx ! I merged the PR because I've already approved it. What do you think about release a new version?
Published as 5.1.0 with rescript breaking changes!
Hello.
Looks like
NavigationContainerref hasNavigationContainerReftype: packages/native/src/NavigationContainer.tsx#L47These changes will make it possible to use navigation without
navigationprop.