-
-
Notifications
You must be signed in to change notification settings - Fork 136
fix: ensure logger debug calls always return true #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gugaiz
wants to merge
1
commit into
reidmorrison:master
from
penrosehill:fix/logger-debug-return-true
Open
fix: ensure logger debug calls always return true #305
gugaiz
wants to merge
1
commit into
reidmorrison:master
from
penrosehill:fix/logger-debug-return-true
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify logger debug behavior to return true regardless of the log level, ensuring dependent processes like state machines in solidus function correctly
Unfortunately the ship has sailed on making a breaking change like this when Semantic Logger has behaved this way for over 10 years. We are very likely to break existing code for someone that looks at the return code.
If the return code has no meaning, then it should nil instead of true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Issue #304
Description of changes
Modify logger debug behavior to return true regardless of the log level, ensuring dependent processes like state machines in solidus function correctly
Context
In Rails’ default logger, a call to
logger.debugalways returnstrueregardless of the log level, preserving compatibility with code that relies on the return value. However, rails_semantic_logger deviates from this behavior, returningfalsewhen the log level does not allow the message to be logged. This discrepancy can cause unexpected issues in frameworks like Solidus or other applications using state machines or similar logic.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.