Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Sanchitc05/issue1524 #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sanjay-kv merged 2 commits into recodehive:main from sanchitc05:sanchitc05/issue1524
Oct 24, 2024
Merged

Conversation

@sanchitc05
Copy link
Member

@sanchitc05 sanchitc05 commented Oct 24, 2024
edited
Loading

Description

This pull request addresses two key visual issues on the website.

  1. Content Misalignment: Adjusted the layout of content inside the "languages" and "milestones" sections to ensure proper alignment within their respective divs. The content now fits perfectly within the containers by adding padding, fixing overflow, and ensuring word wrapping.

  2. Twitter Logo Disappearing in Dark Mode: Fixed the issue where the Twitter logo was not visible in dark mode by using a media query to detect dark mode and switch to a light-colored logo version. Alternatively, the filter invert(1) was applied to adjust the visibility of the logo.

These changes enhance the site's usability and ensure a consistent experience across different themes.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@sanjay-kv sanjay-kv merged commit a37ec8f into recodehive:main Oct 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanjay-kv sanjay-kv sanjay-kv approved these changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /