-
-
Notifications
You must be signed in to change notification settings - Fork 205
build: configure rollup-plugin-dts to use special compilerOptions #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This restores importing React and the ESLint rule react/react-in-jsx-scope to preserve React 16 compatibility. This also moves some types around so themes can be exported as a standalone with its own TypeScript config.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4724175:
|
@arturbien @luizbaldi although this exported files on the correct locations, it still didn't generate one file per theme as expected.
Any objection to either:
- Export one bundle with all themes in one object
- Export the themes together with
react95and only have one entry
Ideally we should expose all components and themes in a way that would allow devs to import only the things they need (like MUI does):
import Button from '@mui/material/Button';
I am worried that if we bundle themes together, we're going to increase the bundle size. Especially if we keep adding more and more themes. I'll try to look into that during the weekend.
@luizbaldi any ideas?
@arturbien then we need to change rollup for the main entry too, it currently bundles the entire file into one export.
#329 works nicely now.
An alternative to #329, passing specific TypeScript
compilerOptionstorollup-plugin-dts.