-
Couldn't load subscription status.
- Fork 27
fix: prevent scrolling when focus trap cycles back into the modal #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
also fixes a small issue with the `alertdialog` role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this is over complicating things? people shouldn't actually be rendering modals into not-the-body
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this was necessary to resolve the TypeError: Converting circular structure to JSON error in the tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'm confused why tho. It doesn't seem necessary in real life. Gotta dig in a bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in "Scroll"
Uh oh!
There was an error while loading. Please reload this page.
also fixes a small issue with the
alertdialogrole fixing #81 and addresses the bug noted in react-bootstrap/react-bootstrap#6579I was hoping the scroll thing would be as simple as
preventDefaulton the incomingfocusevent but that doesn't seem to cut it in Chrome at least, so back to good ol manual scroll position setting.