Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add circle ci #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanielZlotin merged 15 commits into react-native-community:master from gengjiawen:master
Jun 19, 2018
Merged

Conversation

@gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Jun 18, 2018
edited
Loading

Check build history: https://circleci.com/gh/gengjiawen/jsc-android-buildscripts/tree/master.
I doesn't find the say command, so I change it to echo.

cd $ROOTDIR

npm run info
say -v Carmit "I am not slacking off, my code's compiling."
Copy link
Collaborator

@DanielZlotin DanielZlotin Jun 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣 can't believe I left this in 🤣

Copy link
Collaborator

DanielZlotin commented Jun 19, 2018
edited
Loading

Thank you!
I actually have some beefy macpro's dedicated to OSS CI (using Jenkins as a server) so it might be a better idea than using circleCI but let's add it for now until we migrate there

@DanielZlotin DanielZlotin merged commit 093bc29 into react-native-community:master Jun 19, 2018
Copy link
Member Author

Do you plan to upload the docker image to Dockerhub ? It will be easy to adapt to any ci system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DanielZlotin DanielZlotin DanielZlotin left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /