-
Notifications
You must be signed in to change notification settings - Fork 207
Propose feature: add useLinking custom hook #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propose feature: add useLinking custom hook #404
Conversation
Two of three things in this hook seem to be just a call to Linking.something, which I don't think is very useful. Maybe this could be a deeplink-specific hook?
⚠️ No Changeset found
Latest commit: 99f1ab3
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@pvinis Could you take another look?
Uh oh!
There was an error while loading. Please reload this page.
Summary
Hey folks, I'm proposing this new hook to deal with urls built around the native Linking API and some other methods if useful. I've tested in a real app and seems to work fine but also included some tests.
Test Plan
What's required for testing (prerequisites)?
yarnandyarn testWhat are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md