-
Couldn't load subscription status.
- Fork 149
Update to Node 18.20 for Memory Leak Fix #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@cortinico suggestions on the failed circleci build?
@cortinico suggestions on the failed circleci build?
The CI failed because the build took more than 1 hour to complete.
In order to merge this we'll have fix the CI by either:
- Migrating to GitHub Actions
- Updating the
buildscript to don't attempt to build all the architectures
see also #226
@cortinico started testing a fix for #226 in #227 - it looks like the publish already has a GitHub actions workflow so it just needed the build half ported
@TiKevin83 amazing so can you rebase this PR and we can merge it afterwards 👍
Updating to Node 18.20 will fix a memory leak regression that has been affecting Jest for a while, see here for references: jestjs/jest#11956 nodejs/node#51004
b8fcf01 to
14ff60a
Compare
@TiKevin83 amazing so can you rebase this PR and we can merge it afterwards 👍
done - you may also want to remove the CircleCI integration that's still showing up on these PR checks
done - you may also want to remove the CircleCI integration that's still showing up on these PR checks
Yeah I already disabled it but for some reason it keep getting re-enabled
Updating to Node 18.20 will fix a memory leak regression that has been affecting Jest for a while, see here for references:
jestjs/jest#11956
nodejs/node#51004