Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: use a custom error when items are not files #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rolandjitsu wants to merge 1 commit into main
base: main
Choose a base branch
Loading
from feat/custom-err

Conversation

@rolandjitsu
Copy link
Collaborator

@rolandjitsu rolandjitsu commented Nov 27, 2024

What kind of change does this PR introduce?

  • Bug Fix
  • Feature
  • Refactoring
  • Style
  • Build
  • Chore
  • Documentation
  • CI

Did you add tests for your changes?

  • Yes, my code is well tested
  • Not relevant

If relevant, did you update the documentation?

  • Yes, I've updated the documentation
  • Not relevant

Summary

Use a custom error for the not a file case so that users can inspect the item if they wish to.

Does this PR introduce a breaking change?

Probably not.

Other information

Copy link
Collaborator Author

Hmm, interesting. Locally the tests are passing on node v20 😆 I'll have a look at it later this week,
jonkoops reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonkoops jonkoops Awaiting requested review from jonkoops

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /