Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add phpunit 11 support #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pieterocp wants to merge 2 commits into rdohms:master
base: master
Choose a base branch
Loading
from pieterocp:add-phpunit-11-support

Conversation

@pieterocp
Copy link

@pieterocp pieterocp commented Jan 27, 2025
edited by jrfnl
Loading

Allow for phpunit version 11.* to be used, addressing #85 + should handle the case of https://github.com/rdohms/phpunit-arraysubset-asserts/pull/81/files#r1557304228 so thank you for the suggestion.

Did run the job using nektos/act and outside of being ratelimited if I ran several at once, it seemed to generally work. The version constraints can probably be changed a bit though.

Tested with inside a project, which has this composer installed, plus ran tests locally on using a phpunit.phar installation.

Closes #83, #85, #87

batopa, kohlerdominik, and wilr reacted with eyes emoji
Copy link
Collaborator

jrfnl commented Jan 28, 2025

@pieterocp Just a thought: if you literally copy someone else's code .... you may want to give them credit...

pieterocp reacted with thumbs up emoji

pieterocp and others added 2 commits January 28, 2025 06:45
Credited to dmaicher
Co-authored-by: dmaicher <dmaicher@users.noreply.github.com>
... this version works with most/all phpunit installations
Credit to jrfnl for the suggestion and the phar test setup from Yoast
Co-authored-by: jrfnl <jrfnl@users.noreply.github.com>
Copy link
Author

@pieterocp Just a thought: if you literally copy someone else's code .... you may want to give them credit...

Apologies, added to the commit messages the folks who's work I glued together. So thank you @jrfnl and @dmaicher.

jrfnl reacted with thumbs up emoji

Copy link
Collaborator

jrfnl commented Jan 28, 2025

@pieterocp Appreciated.

pieterocp reacted with thumbs up emoji

Copy link

@rdohms could you review this PR?

Copy link

any news about this?

Copy link

@rdohms can you please take a look at this or give the repo to another maintainer?

steveneaston added a commit to amiqus/phpunit-arraysubset-asserts that referenced this pull request Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@LukeTowers LukeTowers LukeTowers approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /