Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Use ‘expect’ only not ‘should’ in specs #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
raysrashmi wants to merge 3 commits into master from use-expect-only
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/ruby-stackoverflow/client/response_data.rb
View file Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@

module RubyStackoverflow
class Client
class ResponseData
attr_reader :data, :has_more, :error

def initialize(response, klass)
if response[:items].nil?
@error = StackoverflowError.new(response)
@error = StackoverflowError.new(response)
else
@data = format_data(response[:items], klass)
@has_more = response[:has_more]
Expand Down
18 changes: 12 additions & 6 deletions spec/ruby-stackoverflow/badges_spec.rb
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ module RubyStackoverflow
it 'should find badges' do
VCR.use_cassette('badges') do
response = RubyStackoverflow.badges({min: 'gold', max: 'bronze', sort: 'rank'})
response.data.is_a?(Array).should be_truthy

expect(response.data.is_a?(Array)).to be_truthy
expect(response.data.count).to eq(30)
expect(response.data.first.name).to eq('cryptography')
end
Expand All @@ -18,7 +19,8 @@ module RubyStackoverflow
it 'should find badges by ids' do
VCR.use_cassette('badges_by_ids') do
response = RubyStackoverflow.badges_by_ids([263, 264], {min: 'gold', max: 'bronze', sort: 'rank'})
response.data.is_a?(Array).should be_truthy

expect(response.data.is_a?(Array)).to be_truthy
expect(response.data.count).to eq(2)
expect(response.data.first.name).to eq('cryptography')
end
Expand All @@ -27,7 +29,8 @@ module RubyStackoverflow
it 'should find badges by name' do
VCR.use_cassette('badges_by_name') do
response = RubyStackoverflow.badges_by_name({inname: 'teacher',min: 'gold', max: 'bronze', sort: 'rank'})
response.data.is_a?(Array).should be_truthy

expect(response.data.is_a?(Array)).to be_truthy
expect(response.data.count).to eq(1)
expect(response.data.first.name).to eq('Teacher')
end
Expand All @@ -36,7 +39,8 @@ module RubyStackoverflow
it 'should find recently added badges' do
VCR.use_cassette('badges_by_recipients') do
response = RubyStackoverflow.badges_between_dates({page: 1, pagesize: 10})
response.data.is_a?(Array).should be_truthy

expect(response.data.is_a?(Array)).to be_truthy
expect(response.data.count).to eq(10)
expect(response.data.first.name).to eq('Nice Answer')
end
Expand All @@ -45,7 +49,8 @@ module RubyStackoverflow
it 'should find recently added badges by ids' do
VCR.use_cassette('badges_by_recipients_by_ids') do
response = RubyStackoverflow.badges_between_dates_by_ids([146, 20],{page: 1, pagesize: 10})
response.data.is_a?(Array).should be_truthy

expect(response.data.is_a?(Array)).to be_truthy
expect(response.data.count).to eq(10)
expect(response.data.first.name).to eq('Nice Question')
end
Expand All @@ -54,7 +59,8 @@ module RubyStackoverflow
it 'should find badges by tags' do
VCR.use_cassette('badges_by_tags') do
response = RubyStackoverflow.badges_by_tags({inname: 'ruby-on-rails',min: 'gold', max: 'bronze', sort: 'rank'})
response.data.is_a?(Array).should be_truthy

expect(response.data.is_a?(Array)).to be_truthy
expect(response.data.count).to eq(7)
expect(response.data.first.name).to eq('ruby-on-rails')
end
Expand Down
6 changes: 4 additions & 2 deletions spec/ruby-stackoverflow/comments_spec.rb
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ module RubyStackoverflow
it 'should fetch comments' do
VCR.use_cassette('comments') do
response = RubyStackoverflow.comments({min: 1, max: 10, sort: 'votes'})
response.data.is_a?(Array).should be_truthy

expect(response.data.is_a?(Array)).to be_truthy
expect(response.data.count).to eq(30)
expect(response.data.first.edited).to eq(false)
expect(response.data.first.score).to eq(10)
Expand All @@ -20,7 +21,8 @@ module RubyStackoverflow
it 'should fetch comments by ids' do
VCR.use_cassette('comments_by_ids') do
response = RubyStackoverflow.comments_by_ids(['129085', '131326'])
response.data.is_a?(Array).should be_truthy

expect(response.data.is_a?(Array)).to be_truthy
expect(response.data.count).to eq(2)
expect(response.data.first.edited).to eq(false)
expect(response.data.first.score).to eq(10)
Expand Down
38 changes: 24 additions & 14 deletions spec/ruby-stackoverflow/question_spec.rb
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,26 @@ module RubyStackoverflow
it 'should get questions' do
VCR.use_cassette('questions') do
response = RubyStackoverflow.questions
response.data.is_a?(Array).should be_truthy
response.data.last.respond_to?(:answer_count).should be_truthy

expect(response.data.is_a?(Array)).to be_truthy
expect(response.data.last.respond_to?(:answer_count)).to be_truthy
end
end

it 'should get questions by id' do
VCR.use_cassette('questions_by_ids') do
response = RubyStackoverflow.questions_by_ids(['19294359'])
response.data.is_a?(Array).should be_truthy
response.data.last.respond_to?(:answer_count).should be_truthy

expect(response.data.is_a?(Array)).to be_truthy
expect(response.data.last.respond_to?(:answer_count)).to be_truthy
end
end

it 'should get answers of questions' do
VCR.use_cassette('questions_answers') do
response = RubyStackoverflow.answers_of_questions(['16067043','19401289'])
response.data.is_a?(Array).should be_truthy

expect(response.data.is_a?(Array)).to be_truthy
expect(response.data.last.answers.count).to eq(1)
expect(response.data.first.answers.last.answer_id).to eq(19401432)
end
Expand All @@ -36,54 +39,61 @@ module RubyStackoverflow
VCR.use_cassette('questions_comments') do
response = RubyStackoverflow.comments_of_questions(['13804832'])
data = response.data.last
response.data.is_a?(Array).should be_truthy
data.respond_to?(:comments).should be_truthy

expect(response.data.is_a?(Array)).to be_truthy
expect(data.respond_to?(:comments)).to be_truthy
expect(data.comments.first.owner[:user_id]).to eq(87189)
end
end

it 'should get linked questions' do
VCR.use_cassette('linked_questions') do
response = RubyStackoverflow.linked_questions(['13804832'])
response.data.is_a?(Array).should be_truthy

expect(response.data.is_a?(Array)).to be_truthy
end
end

it 'should get related questions' do
VCR.use_cassette('related_questions') do
response = RubyStackoverflow.related_questions(['13804832'])
response.data.is_a?(Array).should be_truthy

expect(response.data.is_a?(Array)).to be_truthy
end
end

it 'should get timeline questions' do
VCR.use_cassette('timeline_questions') do
response = RubyStackoverflow.timeline_of_questions(['13804832','16067043'])
data = response.data.first
response.data.is_a?(Array).should be_truthy
data.posts.first.respond_to?(:timeline_type).should be_truthy

expect(response.data.is_a?(Array)).to be_truthy
expect(data.posts.first.respond_to?(:timeline_type)).to be_truthy
expect(data.posts.first.timeline_type).to eq('comment')
end
end

it 'should get featured questions' do
VCR.use_cassette('featured_questions') do
response = RubyStackoverflow.featured_questions({page: 1,pagesize: 1})
response.data.is_a?(Array).should be_truthy

expect(response.data.is_a?(Array)).to be_truthy
end
end

it 'should get unanswered questions' do
VCR.use_cassette('unanswered_questions') do
response = RubyStackoverflow.unanswered_questions({tagged:'rails',pagesize: 1, page: 1})
response.data.is_a?(Array).should be_truthy

expect(response.data.is_a?(Array)).to be_truthy
end
end

it 'should get noanswered questions' do
VCR.use_cassette('noanswered_questions') do
response = RubyStackoverflow.noanswered_questions({tagged:'rails', pagesize: 1, page: 1})
response.data.is_a?(Array).should be_truthy

expect(response.data.is_a?(Array)).to be_truthy
end
end
end
Expand Down
Loading

AltStyle によって変換されたページ (->オリジナル) /