Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

remove unnecessary file and optimize query #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SuMingXuan wants to merge 2 commits into rails-engine:master from SuMingXuan:master

Conversation

@SuMingXuan
Copy link

@SuMingXuan SuMingXuan commented Mar 23, 2021

No description provided.

Copy link

codecov bot commented Mar 23, 2021
edited
Loading

Codecov Report

Merging #31 (bfef228) into master (ba31caa) will increase coverage by 9.30%.
The diff coverage is 100.00%.

❗ Current head bfef228 differs from pull request most recent head 885ca10. Consider uploading reports for the commit 885ca10 to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@
## master #31 +/- ##
==========================================
+ Coverage 87.50% 96.80% +9.30% 
==========================================
 Files 8 7 -1 
 Lines 104 94 -10 
==========================================
 Hits 91 91 
+ Misses 13 3 -10 
Impacted Files Coverage Δ
...trollers/notifications/notifications_controller.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba31caa...885ca10. Read the comment docs.

Copy link
Author

关了, 想了下实例变量一定会被使用,这种算是负优化。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /