Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix #12 Unknown key :optional error in Rails 4.2 #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Parent: Fix link_to
huacnlee wants to merge 2 commits into master from fix/model-optional-with-rails-4-2

Conversation

@huacnlee
Copy link
Member

@huacnlee huacnlee commented Mar 6, 2018

Implement way to test for Rails 4.2, 5.0, 5.1

Implement way to test for Rails 4.2, 5.0, 5.1
Copy link

codecov bot commented Mar 6, 2018
edited
Loading

Codecov Report

Merging #15 into master will decrease coverage by 5.1%.
The diff coverage is 54.54%.

Impacted file tree graph

@@ Coverage Diff @@
## master #15 +/- ##
==========================================
- Coverage 96.59% 91.48% -5.11% 
==========================================
 Files 7 7 
 Lines 88 94 +6 
==========================================
+ Hits 85 86 +1 
- Misses 3 8 +5
Impacted Files Coverage Δ
lib/notifications/model.rb 86.11% <54.54%> (-13.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ea9fff...782032f. Read the comment docs.

@huacnlee huacnlee force-pushed the fix/model-optional-with-rails-4-2 branch from 015b582 to c345dd0 Compare March 6, 2018 05:27
@huacnlee huacnlee force-pushed the fix/model-optional-with-rails-4-2 branch from c345dd0 to 782032f Compare March 6, 2018 05:31
@huacnlee huacnlee deleted the fix/model-optional-with-rails-4-2 branch March 6, 2018 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /