Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added Tutorial 6 & Improved, fixed bug, cleaned up code for Go language #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelklishin merged 2 commits into rabbitmq:master from pilwon:go_improvements
Aug 19, 2014
Merged

Added Tutorial 6 & Improved, fixed bug, cleaned up code for Go language #39

michaelklishin merged 2 commits into rabbitmq:master from pilwon:go_improvements
Aug 19, 2014

Conversation

@pilwon
Copy link
Contributor

@pilwon pilwon commented Aug 19, 2014

  • Added missing Tutorial 6 code.
  • Improved overall code consistency and organization.
  • Fixed bugs (ex: not setting exclusive tag when the tutorial article mentions it, error in arg parsing)
  • Cleaned up minor things. (ex: receiver/worker/server keeps running and consuming messages)

@pilwon pilwon changed the title (削除) Added Tutorial 6 to Go language + Improved, fixed bug, cleaned up code (削除ここまで) (追記) Added Tutorial 6 & Improved, fixed bug, cleaned up code for Go language (追記ここまで) Aug 19, 2014
Copy link
Contributor

I don't want to be a pain in the neck but in the future, please do not submit a pull request that adds something AND also modifies formatting/"cleans up" a lot of other files. This is just not polite to the maintainer.

michaelklishin added a commit that referenced this pull request Aug 19, 2014
Added Tutorial 6 & Improved, fixed bug, cleaned up code for Go language
@michaelklishin michaelklishin merged commit 30228db into rabbitmq:master Aug 19, 2014
@pilwon pilwon deleted the go_improvements branch August 23, 2014 22:16
Copy link
Contributor Author

pilwon commented Aug 23, 2014

@michaelklishin Gotcha. Was my PR helpful at all?

Copy link
Contributor

@pilwon well, I merged it ;)

Copy link
Contributor Author

pilwon commented Aug 24, 2014

@dumbbell dumbbell modified the milestone: n/a Mar 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

n/a

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /