-
Notifications
You must be signed in to change notification settings - Fork 11
Drop qmlobjdef, support deep subproperties in qmlprop #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmlobjdef supported only two components, a different format was needed to support assignments like Drag.hotSpot.x: width / 2. Let's just use qmlprop with name = 'Drag.hotSpot.x' for that, instead of defining a separate token type for properties with two components. Refs: qmlweb/qmlweb#280
+1 This (and the corresponding change in qmlweb) fixes parsing of a use-case I have that's setting a module-qualified attached property (e.g. ModuleQualifer.AttachedObject.property: "foo").
I'm not 100% convinced to be honest. Wouldn't it be better to create proper AST for the names?
See #19 for an alternative approach, that creates proper AST.
Closing in favor of #19.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
qmlobjdefsupported only two components, a different format was needed to support assignments likeDrag.hotSpot.x: width / 2.Let's just use
qmlpropwithname = 'Drag.hotSpot.x'for that, instead of defining a separate token type for properties with two components.Refs: qmlweb/qmlweb#280
/cc @akreuzkamp