-
Notifications
You must be signed in to change notification settings - Fork 71
Make looking for badges directory recursive. #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the look up of Gamifying badges be directory recursive so that it finds them no matter how deep the folder structure is. This allows developers to place badges within the `Gamify/Badges` directory in a more structured way rather than all badges right in the root of that directory.
ansezz
ansezz
approved these changes
Mar 7, 2020
Just checking the status of this PR. Been almost 3 years hoping for this to be merged 😞
ansezz
ansezz
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows badges to be placed within other folders.
The only problem I see happening is that right now the
BadgeTypeclass does afirstOrNewto record the badge in the database solely by name. If two badges are name the same but in different folders they would over write each other. This could be avoided by adding a column to the database with the full badge namespace and doing afirstOrNewbased on name and namespace.Otherwise, this code will find badges recursively just fine.