- 
 
- 
  Notifications
 You must be signed in to change notification settings 
- Fork 33.3k
 gh-140373: Correctly emit PY_UNWIND event when generator is closed
 #140767
 
 New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
 
 gh-140373: Correctly emit PY_UNWIND event when generator is closed
 
 #140767
 Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks for fixing this.
Thanks for the review, @markshannon!
Could you please merge this? Unfortunately, I don't have access to this "magic" button. Sorry, if this is not appropriate.
Thanks @efimov-mikhail for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖
...losed (pythonGH-140767) (cherry picked from commit d17f28f) Co-authored-by: Mikhail Efimov <efimov.mikhail@gmail.com>
Sorry, @efimov-mikhail and @markshannon, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d17f28fed5cfbb400f8dd9826c67d87c65f261a0 3.13
GH-140816 is a backport of this pull request to the 3.14 branch.
GH-140821 is a backport of this pull request to the 3.13 branch.
Uh oh!
There was an error while loading. Please reload this page.
PY_UNWINDnot being delivered when a generator is closed/garbage collected #140373