-
-
Notifications
You must be signed in to change notification settings - Fork 33.3k
[3.13] gh-140551: Fix dict crash if clear is called at lookup stage (GH-140558) #140744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kumaraditya303
merged 2 commits into
python:3.13
from
efimov-mikhail:issue-140551-dict_clear_at_lookup-3.13
Oct 30, 2025
Merged
[3.13] gh-140551: Fix dict crash if clear is called at lookup stage (GH-140558) #140744
kumaraditya303
merged 2 commits into
python:3.13
from
efimov-mikhail:issue-140551-dict_clear_at_lookup-3.13
Oct 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@efimov-mikhail
efimov-mikhail
requested review from
markshannon and
methane
as code owners
October 29, 2025 09:44
...age (python#140558) Co-authored-by: Inada Naoki <songofacandy@gmail.com>
methane
methane
approved these changes
Oct 29, 2025
We can't merge this now.
I've reproduced CI fail of test.test_io.PyIOTest.test_garbage_collection on my machine with TSAN.
With the last change CI is green and I think we can merge it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
dictifhash__eq__function has side effects #140551