Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[appveyor] Fix coverage by installing sdist version #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pquentin wants to merge 1 commit into python-trio:master from pquentin:master

Conversation

@pquentin
Copy link
Member

@pquentin pquentin commented Dec 27, 2017

This is closer to what we do in Travis. However, async_generator.__file__ was not pointing to the correct path (shown by pip show -f async_generator), so I decided to build it manually. This is probably quite brittle, but at least it currently works.

Fixes #6.

Copy link

codecov bot commented Dec 27, 2017
edited
Loading

Codecov Report

Merging #7 into master will decrease coverage by 8.08%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@
## master #7 +/- ##
==========================================
- Coverage 100% 91.91% -8.09% 
==========================================
 Files 5 5 
 Lines 581 581 
 Branches 48 48 
==========================================
- Hits 581 534 -47 
- Misses 0 47 +47
Impacted Files Coverage Δ
async_generator/__init__.py 0% <0%> (-100%) ⬇️
async_generator/util.py 42.85% <0%> (-57.15%) ⬇️
async_generator/impl.py 74.17% <0%> (-25.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e303e07...c7909c9. Read the comment docs.

Copy link
Member Author

I'm not sure why the coverage is lower. And it looks like there's work left for the codecov integration in Appveyor.

Copy link
Member Author

Closing as I'm not sure this improves anything. If someone else comes along maybe they'll be able to continue that work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

appveyor coverage isn't working

1 participant

AltStyle によって変換されたページ (->オリジナル) /