-
Couldn't load subscription status.
- Fork 249
list is tainted by calling list.append(TAINT) #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinHock
KevinHock
approved these changes
Nov 1, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really great :D
else:
raise Exception('Definition was neither FunctionDef or ' +
'ClassDef, cannot add the function ')
elif (
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely elif
Taint is propagated by: ``` list += [TAINT] list = list + TAINT ``` but with lists we often use a function to mutate the list: ``` list = [] list.append(TAINT) list.insert(0, TAINT) list.extend(TAINT) ``` Previously this didn't taint `list` so we had FALSE NEGATIVES. Now `list.append(TAINT)` is treated like augmented assignment, so list will be tainted. `list += list.append(TAINT)` Of course this wouldn't work as real code since `append` returns `None` but it is how you can think about this function which mutates `list`. The same goes for `set.add()`, `list.extend()`, `list.insert()`, `dict.update()`, although we aren't actually doing type checking, just looking at the name of the method.
@bcaller
bcaller
force-pushed
the
appendaddextendinsert
branch
from
November 1, 2018 14:57
72682a0 to
7847d01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taint is propagated by:
but with lists we often use a function to mutate the list:
Previously this didn't taint
listso we had FALSE NEGATIVES.Now
list.append(TAINT)is treated like augmented assignment, so listwill be tainted.
list += list.append(TAINT)Of course this wouldn't work as real code since
appendreturnsNonebut it is how you can think about this function which mutates
list.The same goes for
set.add(),list.extend(),list.insert(),dict.update(), although we aren't actually doing type checking, justlooking at the name of the method.