-
Notifications
You must be signed in to change notification settings - Fork 249
Transform all async ast nodes into sync nodes #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that they can be handled identically. Sync and async nodes propagate taint in exactly the same way. Awaits are more or less removed: `return await x()` is converted into `return x()`. Any AsyncFunctionDef is converted to a FunctionDef. Same for AsyncFor and AsyncWith. Using a transformer makes it easier to replace awaits everywhere. We have lots of places where we do `isinstance(node, ast.Call)` but for these we want it to function like `isinstance(node, ast.Call) or (isinstance(node, ast.Await) and isinstance(node.value, ast.Call))`
This is genius! 😁 I'll review later today
KevinHock
KevinHock
approved these changes
Jul 31, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! 🚢
from pyt.core.transformer import AsyncTransformer
class TransformerTest(unittest.TestCase):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great tests :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Transform all async ast nodes into sync nodes ...
so that they can be handled identically. Sync and async nodes propagate
taint in exactly the same way.
Awaits are more or less removed:
return await x()is converted intoreturn x().Any AsyncFunctionDef is converted to a FunctionDef.
Same for AsyncFor and AsyncWith.
Using a transformer makes it easier to replace awaits everywhere (c.f. a different attempt at https://github.com/bcaller/pyt/commits/await ).
We have lots of places where we do
isinstance(node, ast.Call)but for these we want it to function likeisinstance(node, ast.Call) or (isinstance(node, ast.Await) and isinstance(node.value, ast.Call))