-
Notifications
You must be signed in to change notification settings - Fork 249
Tox, travis and requirements #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
029d644 to
3b5b8a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for doing this :) I missed it in my massive 'put everything into their own folders' re-org
.travis.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have somewhere around 90% coverage currently, can you adjust it to whatever it is currently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I was misreading the coverage report I think. Because pyt/vulnerabilities/vulnerability_helper.py has coverage of 76%, but overall it's 90%. I'll fix this tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep it aligned with this as well I suppose.
3b5b8a8 to
1b77a80
Compare
In commit 11bcd2d Remove unused function: valid_date an unused import was left in. With the next commit, tox & travis should fail: F401 'datetime.datetime' imported but unused
Requirements: Requirements files aren't used. Requirements.txt and setup.py had odd requirements that I can't see used anywhere. Requirements-dev.txt had conflicting packages (flake8 wants specific versions of pyflakes and pycodestyle). Tox & travis: Split tox into a test, coverage and lint phase. Run either: tox tox -e py36 tox -e cover tox -e lint Tox and travis will now fail the lint / build on flake8 errors to avoid non-compliant code being merged. (--exit-zero removed) Coverage will fail for now, so let's set it really low in travis for now. McCabe complexity is annoying and dealt with better by codeclimate so I bumped it up from 10 to 11 so it won't fail at the moment.
1b77a80 to
d55cbc0
Compare
I put the code coverage back to 91%. I'd been reading the output incorrectly. 🚢
Awesome :)
Requirements:
Requirements files aren't used. Requirements.txt and setup.py had odd
requirements that I can't see used anywhere. Requirements-dev.txt had
conflicting packages (flake8 wants specific versions of pyflakes and
pycodestyle).
Tox & travis:
Split tox into a test, coverage and lint phase. Run either:
Tox and travis will now fail the lint / build on flake8 errors to
avoid non-compliant code being merged. (
--exit-zeroremoved)Coverage will fail for now, so let's not put it in the travis build yet.
McCabe complexity is annoying and dealt with better by codeclimate so I
bumped it up from 10 to 11 so it won't fail at the moment.