Add Currency Converter #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

pawangeek merged 5 commits into python-geeks:main from maheshschand:currency-convertor

Oct 9, 2020

Merged

Add Currency Converter #69

pawangeek merged 5 commits into python-geeks:main from maheshschand:currency-convertor

Oct 9, 2020

Conversation

@maheshschand

Copy link

Contributor

@maheshschand maheshschand commented Oct 9, 2020 •

edited

Loading

Pull Request Template

script name - currency_converter.py

What have you Changed

Added a script to convert currency of one country to that of other country

Issue no.(must) - #43

Self Check(Tick After Making pull Request)

This issue was assigned to me.
One Change in one Pull Request
My file is in proper folder (Name of folder should be in lowercase with no space in between)
I am following clean code and Documentation and my code is well linted with flake8.
I have added README.md and requirements.txt with my script

If issue was not assigned to you Please don't make a PR. It will marked as invalid.

maheshschand added 3 commits

October 9, 2020 08:03

@maheshschand


 Add Currency Covertor

2c35273

@maheshschand


 Update README

@maheshschand


 Update currency_convertor.py

8ed369f

github-actions[bot]

github-actions bot reviewed

Oct 9, 2020

View reviewed changes

Copy link

Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!! 🎉 @maheshschand for making your first PR. We will review the changes soon and merge finally.😊 Do give a star ⭐ meanwhile if you like this project.