Adding To-Do List Application #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

pawangeek merged 6 commits into python-geeks:main from aayuv17:main

Oct 8, 2020

Merged

Adding To-Do List Application #52

pawangeek merged 6 commits into python-geeks:main from aayuv17:main

Oct 8, 2020

Conversation

@aayuv17

Copy link

Contributor

@aayuv17 aayuv17 commented Oct 8, 2020

Pull Request Template

script name - To-Do List Application

What have you Changed
Added a todo list application made using Python's flask framework

Issue no.(must) - #35

Self Check(Tick After Making pull Request)

This issue was assigned to me.
One Change in one Pull Request
My file is in proper folder (Name of folder should be in lowercase with no space in between)
I am following clean code and Documentation and my code is well linted with flake8.
I have added README.md and requirements.txt with my script

aayuv17 added 4 commits

October 8, 2020 19:50

@aayuv17


 create app.py

4d414c1

@aayuv17


 create html file

3290d53

@aayuv17


 create styles.css

0fd7bf8

@aayuv17


 create README.md

d46c906

@pawangeek pawangeek linked an issue

Oct 8, 2020

that may be closed by this pull request

Todo App #35

Closed

5 tasks

@pawangeek

Copy link

Contributor

pawangeek commented Oct 8, 2020

Hey @aayuv17. Can you please enable linting in code? You can use this site http://pep8online.com/ to check your .py file.

aayuv17 added 2 commits

October 8, 2020 21:36

@aayuv17


 updated app.py

031efa1

@aayuv17


 updated app.py

d8a32b5

@aayuv17

Copy link

Contributor Author

aayuv17 commented Oct 8, 2020

Hey, so I have performed linting on the python code...just wanted to point out that the site you recommended and the tool being used for checking are following different rules in some cases so I installed the flake8 module and used that. Maybe if others face issues with the site you can tell them to do the same.