Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Mar 31, 2020. It is now read-only.

overjoyed otolaryngologists #4

Open
ravenkls wants to merge 58 commits into python-discord:master
base: master
Choose a base branch
Loading
from ravenkls:master

Conversation

@ravenkls
Copy link

@ravenkls ravenkls commented Feb 21, 2019

No description provided.

ravenkls and others added 30 commits February 21, 2019 21:59
ravenkls and others added 27 commits February 26, 2019 18:48
...tricted length of fields to a max of 2 characters and restricted values to numbers only
Copy link
Member

jb3 commented Mar 7, 2019
edited
Loading

I really like some of the ideas you've come up with to put a twist on the game. Though, not a huge amount of code and a lot of it was generated by Qt.

Pathlib could have been used to generate some of the paths where you instead used os to generate your paths.

Copy link
Author

ravenkls commented Mar 7, 2019

Thanks for the feedback :) Although I think you understate the amount we produced, no 'code' was generated by Qt, unless you count a compiled resource file as code ̄_(ツ)_/ ̄

Copy link
Member

jb3 commented Mar 7, 2019

Ah yeah the resource file did throw me off a bit (216,000 additions 👀). All other code was of high code quality 👍.

ravenkls reacted with laugh emoji

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /